[PATCH v3 inputproto] Unbreak protocol ABI for XIAllowEvents - inputproto 2.1.99.6

Keith Packard keithp at keithp.com
Wed Feb 8 09:00:42 PST 2012


<#part sign=pgpmime>
On Wed,  8 Feb 2012 19:18:18 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> XIAllowEvents was extended with touchid and grab_window in
> 2ea2f99f4fe1dcd3b8e539ca41c482fc40a0533d. This extended the size of
> the request from 12 to 20 but also broke the ABI. Older server
> match the request size exactly, so compiling libXi 1.5 against
> inputproto 2.2 and then running it against a pre-XI 2.2 server causes a
> BadLength for any XIAllowEvent request.
> 
> Add a new request struct for the new data.

Should the protocol header include the definition for
X_XI2_2AllowEvents? (see also comment from the library change)

Other than that,

Reviewed-by: Keith Packard <keithp at keithp.com>

-- 
keith.packard at intel.com


More information about the xorg-devel mailing list