[PATCH] glx/dri2: initialise api to avoid indirect rendering failing randomly

Ian Romanick idr at freedesktop.org
Mon Dec 17 10:02:16 PST 2012


On 12/16/2012 09:40 PM, Dave Airlie wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Running glxinfo under indirect rendering would randomly fail against the
> intel driver, as it would create a context with no attribs, and then the
> api value would be passed to the driver uninitialised.

Someone else submitted this patch months ago, and I'd swear it got 
applied then.  I've had bugs #56042 and #57784 on my todo list for 
sometime now...  I suspect this will take care of both. :(

> Signed-off-by: Dave Airlie <airlied at redhat.com>

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

> ---
>   glx/glxdri2.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/glx/glxdri2.c b/glx/glxdri2.c
> index bce1bfa..b26e501 100644
> --- a/glx/glxdri2.c
> +++ b/glx/glxdri2.c
> @@ -514,7 +514,7 @@ create_driver_context(__GLXDRIcontext * context,
>           unsigned minor_ver;
>           uint32_t flags;
>           int reset;
> -        int api;
> +        int api = __DRI_API_OPENGL;
>
>           if (num_attribs != 0) {
>               if (!dri2_convert_glx_attribs(screen, num_attribs, attribs,
>



More information about the xorg-devel mailing list