[PATCH fixesproto] CreatePointerBarrier takes a window, not a drawable

Jasper St. Pierre jstpierre at mecheye.net
Sun Dec 2 20:54:51 PST 2012


You should probably rename the 'drawable' field to 'window'.


On Sun, Dec 2, 2012 at 11:53 PM, Peter Hutterer <peter.hutterer at who-t.net>wrote:

> Technically this is a change in the protocol, but we've never supported
> anything but a Window. Also note that it's already called "window" in the
> wire struct.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> I also suspect that the number of compatible X11 implementations that
> provide support for fixes 5.0/pointer barriers is small enough that this
> change in protocol goes by unnoticed.
>
>  fixesproto.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fixesproto.txt b/fixesproto.txt
> index 5903ac9..1828ba8 100644
> --- a/fixesproto.txt
> +++ b/fixesproto.txt
> @@ -606,13 +606,13 @@ essentially the same reason.
>  CreatePointerBarrier
>
>                 barrier:                    BARRIER
> -               drawable:                   DRAWABLE
> +               drawable:                   Window
>                 x1, y2, x2, y2:             INT16
>                 directions:                 CARD32
>                 devices:                    LISTofDEVICEID
>
>         Creates a pointer barrier along the line specified by the given
> -       coordinates on the screen associated with the given drawable.  The
> +       coordinates on the screen associated with the given window.  The
>         barrier has no spatial extent; it is simply a line along the left
>         or top edge of the specified pixels.  Barrier coordinates are in
>         screen space.
> --
> 1.7.11.7
>
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20121202/02ab4a21/attachment.html>


More information about the xorg-devel mailing list