[resend PATCH] sdksyms.sh may not be executable.

Gaetan Nadon memsize at videotron.ca
Fri Sep 30 06:25:09 PDT 2011


On Fri, 2011-09-30 at 14:36 +0200, Matthieu Herrb wrote:

> Use $(SHELL) to run it.
> 
> Signed-off-by: Matthieu Herrb <matthieu.herrb at laas.fr>
> ---
>  hw/xfree86/Makefile.am |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/xfree86/Makefile.am b/hw/xfree86/Makefile.am
> index e3ef14f..4f08772 100644
> --- a/hw/xfree86/Makefile.am
> +++ b/hw/xfree86/Makefile.am
> @@ -111,7 +111,7 @@ CLEANFILES = sdksyms.c sdksyms.dep
>  EXTRA_DIST += sdksyms.sh
>  
>  sdksyms.dep sdksyms.c: sdksyms.sh
> -	CPP='$(CPP)' AWK='$(AWK)' $(srcdir)/sdksyms.sh $(top_srcdir) $(CFLAGS) $(AM_CFLAGS) $(INCLUDES)
> +	CPP='$(CPP)' AWK='$(AWK)' $(SHELL) $(srcdir)/sdksyms.sh $(top_srcdir) $(CFLAGS) $(AM_CFLAGS) $(INCLUDES)
>  
>  SDKSYMS_DEP = sdksyms.dep
>  include $(SDKSYMS_DEP)


For the benefit of the readers, can you mention in the commit text under
which circumstances the script is not executable?
Doesn't git work the same way on all platforms? rwxr-xr-x sdksyms.sh

In hw/xquartz/bundle
install-data-hook:

	$(srcdir)/mk_bundke.sh $(srcdir)

I am sure there is a good reason,

Reviewed-by: Gaetan Nadon <memsize at videotron.ca>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110930/69b4681a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110930/69b4681a/attachment-0001.pgp>


More information about the xorg-devel mailing list