[PATCH xf86-video-vmware] Use dixLookupWindow instead of LookupWindow on Xorg 1.5 & later

Alan Coopersmith alan.coopersmith at oracle.com
Thu Sep 29 06:55:10 PDT 2011


On 09/29/11 06:49 AM, Thomas Hellstrom wrote:
> Alan,
>
> On 09/28/2011 04:31 AM, Alan Coopersmith wrote:
>> The LookupWindow function was deprecated in xserver commit ed75b056511ccb4
>> and removed during the Xorg 1.11 merge window by commit 82a8677d9175732.
>>
>> Signed-off-by: Alan Coopersmith<alan.coopersmith at oracle.com>
>> ---
>>
>> Needed for compatibility with the Xorg 1.11 release - only build tested
>> with Xorg 1.11.1, but I tried to preserve compatibility with older releases,
>> following the current status quo of this driver, while making it simple to
>> drop that when it's no longer needed.
>>
>> src/vmwarexinerama.c | 32 ++++++++++++++++++++++++++------
>> 1 files changed, 26 insertions(+), 6 deletions(-)
>
> Thanks for the patch. We have a long-term plan to replace all xorg version
> checks with
> xorg video driver ABI checks, so if you don't min'd I'll change that before
> pushing.

Sure.   That sounds more consistent with the checks in other drivers and should
save you having to define your own symbols for each version - I was just using
the existing checks that were in there currently.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list