[PATCH v2] Address regressions from e8ff555b95baab66cc7d060c1e7f9fdd49d3802f

Alan Coopersmith alan.coopersmith at oracle.com
Thu Sep 22 20:35:56 PDT 2011

On 09/22/11 08:23 PM, Jamey Sharp wrote:
> Reviewed-by: Jamey Sharp<jamey at minilop.net>
> What I said for Alan's patch goes for this one too:
> Seems like there ought to be a better way than listing which compilers
> support it, though. I considered an autoconf test to check whether
> __builtin_constant_p is defined, but that doesn't tell you which
> compiler is pulling in misc.h each time it's used. Which wouldn't be an
> issue if misc.h weren't part of the SDK headers. Phooey.

I didn't see any better way for an exported header - I even went looking into
the changes made to Studio to add the flag, and didn't see anything like a
#define HAS_BUILTIN_CONSTANT_P or any way to tell other than the version number.

	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System

More information about the xorg-devel mailing list