[PATCH] fb: Rename wfbTriangles and wfbTrapezoids

Adam Jackson ajax at redhat.com
Fri Sep 16 08:53:11 PDT 2011

On Thu, 2011-09-15 at 19:29 -0700, Alan Coopersmith wrote:

> On Solaris, I can get the equivalent output with:
> % nm -pg libwfb.so | grep ' fb'
> 00000000000000218380 T fbTrapezoids
> 00000000000000219112 T fbTriangles

This works with GNU binutils as well, at least for unstripped ELF
objects, and the OSX manual page for nm looks like it supports identical
options with identical semantics.  If it works with GNU binutils on
Windows PE objects then I think we'd be set.

> BTW, is it a problem that libfb & libwfb each have a local copy of
> fbOverlayScreenPrivateKeyRec ?  Or is it required that 
> wfbOverlayFinishScreenInit initialize a different private than
> fbOverlayFinishScreenInit and fbOverlayScreenPrivateKeyRec should be added
> to the rename list to simplify finding the right one when debugging?

It's not a functional problem, since fbOverlayScreenPrivateKeyRec is
static and each instance of the overlay code wants its own private key.
But you are correct that debugging a server with both fb and wfb loaded
would be more difficult due to the name collision.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110916/51a872c8/attachment-0001.pgp>

More information about the xorg-devel mailing list