[PATCH xserver 3/3] devbook.am: maintenance update from docbook.am

Gaetan Nadon memsize at videotron.ca
Thu Sep 15 13:56:36 PDT 2011


On Thu, 2011-09-15 at 13:18 -0500, Jeremy Huddleston wrote:

> Ok, then this gets my structural review, but would be nice if someone who really understands docbook looks at invocation.

I would love to as well. However, from a risk management perspective,
this new version is mainly a reshuffle of make targets flags. I use an
identical copy of docbook.am and devbook.am in the 22 modules having
docbook xml. This way we don't have to review 22 differently coded
makefiles performing the exact same programming tasks.

Thanks

> 
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> 
> 
> 
> On Sep 15, 2011, at 8:41 AM, Gaetan Nadon wrote:
> 
> > On Thu, 2011-09-15 at 02:35 -0500, Jeremy Huddleston wrote:
> > 
> >> On Sep 14, 2011, at 9:12 AM, Gaetan Nadon wrote:
> >>> 
> >>> +if HAVE_XMLTO_TEXT
> >>> +noinst_DATA += $(docbook:.xml=.txt)
> >>> +%.txt: %.xml $(chapters)
> >>> +	$(AM_V_GEN)$(XMLTO) $(XMLTO_HTML_FLAGS) txt $<
> >>> +endif HAVE_XMLTO_TEXT
> >> 
> >> ^^^ XMLTO_TEXT_FLAGS ??
> >> 
> >> 
> > 
> > Good observation. The txt format is obtained by first transforming xml
> > to html using the same xsltproc and stylesheet. Then it is converted to
> > text using one of the three tools w3m, lynks or links. Although
> > confusing, it is more accurate to use the same html flags. It also looks
> > strange to have olink flags when you cannot have cross-reference
> > documents between text file.
> > 
> > So this one is good, there were no lack of opportunities for errors.
> > 
> > Thanks
> > _______________________________________________
> > xorg-devel at lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: http://lists.x.org/mailman/listinfo/xorg-devel
> 


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110915/3aa83d9d/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110915/3aa83d9d/attachment.pgp>


More information about the xorg-devel mailing list