[PATCH:libXaw3d] Make laygram.y compatible with bison 2.3 and older

Gaetan Nadon memsize at videotron.ca
Sun Sep 4 18:38:23 PDT 2011


On Sun, 2011-09-04 at 16:27 +0200, walter harms wrote:

> IMHO to have yyparse() etc. is ok. If someone complains we/you can
> revert the change. cleaning up seems more important now.

I did some more searching. I found a couple of posts where name clashing
did occur (not with X). Other modules in X using lex & yacc are the
server and apps, but this module is a library and more prone to name
clashing. Looking at external symbols of X libraries, it shows that they
have a prefix, for example, Xaw. In fact, a prefix for libraries
external symbols is a GNU coding standard.

One thing I don't know is if these yy* symbols should be external
symbols or not. If yes, they should have an Xaw3d prefix, otherwise they
should be made invisible. I don't know if this would be possible,
however.

> 
> What confuses me is why does it come up here (Layout.c)
> I would expect it with Layout.h
> 
> 

Maybe because the author did not want those to be in the public headers
space (include/X11/Xaw3d/Layout.h).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110904/5558d0f7/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110904/5558d0f7/attachment.pgp>


More information about the xorg-devel mailing list