[PATCH inputproto 1/2] Add XIPointerEmulated for emulated events

Daniel Stone daniel at fooishbar.org
Tue Jun 21 12:45:12 PDT 2011


Hi,

On Mon, Jun 20, 2011 at 04:29:55PM +1000, Peter Hutterer wrote:
> On Thu, Jun 09, 2011 at 06:26:00PM +0100, Daniel Stone wrote:
> > @@ -1591,6 +1591,9 @@ KeyRelease, ButtonPress, ButtonRelease, Motion.
> >          KeyRepeat means that this event is for repeating purposes, and
> >          the physical state of the key has not changed.  This is only
> >          valid for KeyPress events.
> > +        PointerEmulated means that the event has been emulated from another
> 
> s/means/signals/

Fixed.

> but either way, Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Thanks.

> of course, one of the questions we should ask ourselves now is whether it is
> is worth adding a serial number to events to allow clients to connect the
> emulated vs real event.

No.  One smooth-scrolling event will generate floor(abs(value)) * 4
emulated button events.  Unless you want to add a list of serials, but
eh.  I think just guaranteeing that the time is identical and that
they'll have XIPointerEmulated should be enough.

Cheers,
Daniel


More information about the xorg-devel mailing list