[PATCH libXi 3/3] make: use AM_V_at rather than AM_V_GEN to prefix the mv command

Gaetan Nadon memsize at videotron.ca
Fri Jun 10 11:06:27 PDT 2011


On Fri, 2011-06-10 at 10:37 -0700, Dan Nicholson wrote:

> On Thu, Jun 9, 2011 at 1:03 PM, Gaetan Nadon <memsize at videotron.ca> wrote:
> > This will prevent outputting a "GEN" prefix. Moving and removing files
> > is not "generating" anything.
> >
> > Signed-off-by: Gaetan Nadon <memsize at videotron.ca>
> > ---
> >  man/Makefile.am |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/man/Makefile.am b/man/Makefile.am
> > index 1b29b72..2181ea9 100644
> > --- a/man/Makefile.am
> > +++ b/man/Makefile.am
> > @@ -166,7 +166,7 @@ SUFFIXES += .txt .xml
> >        $(AM_V_GEN)$(ASCIIDOC) -b docbook -d manpage -o $@ $<
> >  .xml.man:
> >        $(AM_V_GEN)$(XMLTO) man $<
> > -       $(AM_V_GEN)mv -f $(@:.man=.libmansuffix) $@
> > +       $(AM_V_at)mv -f $(@:.man=.libmansuffix) $@
> >
> >  # Invoke asciidoc/xmlto main man page generation for shadow pages
> >  $(libman_shadows):
> > @@ -174,5 +174,5 @@ $(libman_shadows):
> >          rm -f $<; \
> >          $(MAKE) $(AM_MAKEFLAGS) $< || exit 1; \
> >        fi
> > -       $(AM_V_GEN)mv -f $(@:.man=.libmansuffix) $@
> > +       $(AM_V_at)mv -f $(@:.man=.libmansuffix) $@
> >  endif
> 
> AM_V_at silences the output unless you pass V=1, right? I don't have
> the code in front of my. Assuming yes,
> 

Your assumption is correct. I wasn't aware of its existence at the time
I wrote the original code. Thanks

> Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110610/a7364603/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110610/a7364603/attachment.pgp>


More information about the xorg-devel mailing list