Build fixes (was Anything more for xproto 7.0.22?)

[Gaetan Nadon]

On Sun, 2011-06-05 at 03:45 +0200, Cyril Brulebois wrote:

> Gaetan Nadon <memsize at videotron.ca> (04/06/2011):
> > I never used DESTDIR with distcheck. I don't know if it makes sense or
> > not. I tried any way, just to see what happens. The building of
> > x11proto.pdf failed. 
> > 
> >         [warning] /usr/bin/fop: Unable to locate fop in /home/nadon/xorg/src/proto/x11proto/tmp/usr/share/java
> > 
> > Somehow $DESTDIR is used in front of /usr/share/java. That makes think
> > your build did not have DESTDIR set when running distcheck as you would
> > get the same error I had, in theory.
> 
> I never used DESTDIR for distcheck either, but since I'm not building as
> root (!), *something* in there has to come into play and stop automake
> from trying to install to the “bare” location. A non-root make install
> with default settings just can't work.
> 
> Some doc about distcheck is found here:
>   http://www.gnu.org/software/automake/manual/automake.html#Preparing-Distributions
> 
> Looking at the log:
> | test -d xproto-7.0.21/_build || exit 0; \
> | 	dc_install_base=`CDPATH="${ZSH_VERSION+.}:" && cd
> | xproto-7.0.21/_inst && pwd | sed -e 's,^[^:\\/]:[\\/],/,'` \
> | 	  && dc_destdir="${TMPDIR-/tmp}/am-dc-$$/" \
> | 	  && am__cwd=`pwd` \
> | 	  && CDPATH="${ZSH_VERSION+.}:" && cd xproto-7.0.21/_build \
> | 	  && ../configure --srcdir=.. --prefix="$dc_install_base" \
> | 	     \
> | 	  && make  \
> | 	  && make  dvi \
> | 	  && make  check \
> | 	  && make  install \
> 
> So it's assumed --prefix will do everything, and no DESTDIR is used at
> this point (it's checked later that setting DESTDIR works though).
> 
> That's why the “let's ask xorg-sgml-doctools for the prefix” dance and
> its direct use breaks distcheck. Unless one has a user-specific (as
> opposed to system-wide) xorg-sgml-doctools, with appropriate permissions
> on the target directory.
> 


I have submitted a patch for xorg-sgml-doctools so that this situation
no longer occurs. I also need to release a patch for the 21 modules with
DocBook. In any case, don't let that hold the release of the package.
There is no impact to the end user, he won't be able to install the
package anyway if he does not have write permission.


> Mraw,
> KiBi.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110609/9eb9a66f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20110609/9eb9a66f/attachment-0001.pgp>