[PATCH] randr: void function cannot return value

walter harms wharms at bfs.de
Mon Jun 6 08:06:06 PDT 2011



Am 06.06.2011 16:53, schrieb Nicolas Kaiser:
> Providing an argument to return in a function with void return type
> is not allowed by the C standard, and makes the Sun compilers unhappy.
> 
> Signed-off-by: Nicolas Kaiser <nikai at nikai.net>
> Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>
> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  randr/rrcrtc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/randr/rrcrtc.c b/randr/rrcrtc.c
> index d4d8f2a..0437795 100644
> --- a/randr/rrcrtc.c
> +++ b/randr/rrcrtc.c
> @@ -632,7 +632,7 @@ RRModeGetScanoutSize (RRModePtr mode, PictTransformPtr transform,
>  void
>  RRCrtcGetScanoutSize(RRCrtcPtr crtc, int *width, int *height)
>  {
> -    return RRModeGetScanoutSize (crtc->mode, &crtc->transform, width, height);
> +    RRModeGetScanoutSize (crtc->mode, &crtc->transform, width, height);
>  }
>  
>  /*


Is the function really helpful ? maybe it be removed altogether ?

re,
 wh


More information about the xorg-devel mailing list