[PATCH v2 10/25] [libx11] Fixed memory leak by adding Xfree

[Alan Coopersmith]

On 01/31/11 04:02 AM, Erkki Seppälä wrote:
> Variable "colormap_ret" goes out of scope
> 
> Reviewed-by: Ander Conselvan de Oliveira <ander.conselvan-de-oliveira at nokia.com>
> Signed-off-by: Erkki Seppälä <erkki.seppala at vincit.fi>
> ---
>  modules/im/ximcp/imRm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/modules/im/ximcp/imRm.c b/modules/im/ximcp/imRm.c
> index fa86979..3d09b81 100644
> --- a/modules/im/ximcp/imRm.c
> +++ b/modules/im/ximcp/imRm.c
> @@ -2821,6 +2821,8 @@ _XimEncodeLocalPreeditValue(
>  				ic->core.focus_window, &colormap_ret,
>  				&count, (Atom)p->value)))
>  	    return False;
> +
> +	Xfree(colormap_ret);
>      }
>      return True;
>  }

When you're fixing the exact same thing in several functions in the same file,
you could combine them into one patch instead of a series of 3.

Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System