[PATCH:libSM] Bug 33390 - sm.pc: don't export a dependency on ice

Dan Nicholson dbn.lists at gmail.com
Fri Jan 28 16:15:08 PST 2011


On Fri, Jan 28, 2011 at 4:14 PM, Dan Nicholson <dbn.lists at gmail.com> wrote:
> On Fri, Jan 28, 2011 at 12:23 AM, Alan Coopersmith
> <alan.coopersmith at oracle.com> wrote:
>> https://bugs.freedesktop.org/show_bug.cgi?id=33390
>>
>> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
>> ---
>>  sm.pc.in |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/sm.pc.in b/sm.pc.in
>> index ab1261e..3c82387 100644
>> --- a/sm.pc.in
>> +++ b/sm.pc.in
>> @@ -6,7 +6,7 @@ includedir=@includedir@
>>  Name: SM
>>  Description: X Session Management Library
>>  Version: @PACKAGE_VERSION@
>> -Requires: ice xproto
>> -Requires.private: ice
>> +Requires:
>> +Requires.private: ice xproto
>>  Cflags: -I${includedir}
>>  Libs: -L${libdir} -lSM
>
> Yeah, it's about time to drop Requires duplicates. By the way, looking
> at that bug report, the patch that Fedora had for pkg-config that
> would break this has been gone for a couple releases. So, I think we
> should be clear to drop all these if that's the only reason holding it
> up.

Meaning,

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list