[PATCH 06/11] xfree86/dga: DGA2 events are missing the dx/dy information

[Fernando Carrijo]

Ville Syrjala <syrjala at sci.fi> wrote:

> Copy dx/dy from the internal event to the DGA2 Motion/Button events.
> Do the same for Key events for the sake of keeping the code consistent.
> 
> Signed-off-by: Ville Syrjala <syrjala at sci.fi>
> ---
>  hw/xfree86/common/xf86DGA.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/xfree86/common/xf86DGA.c b/hw/xfree86/common/xf86DGA.c
> index 9d0c621..c11b6c3 100644
> --- a/hw/xfree86/common/xf86DGA.c
> +++ b/hw/xfree86/common/xf86DGA.c
> @@ -1064,8 +1064,8 @@ DGAProcessKeyboardEvent (ScreenPtr pScreen, DGAEvent *event, DeviceIntPtr keybd)
>          de.u.u.type = *XDGAEventBase + GetCoreType((InternalEvent*)&ev);
>          de.u.u.detail = event->detail;
>          de.u.event.time = event->time;
> -        de.u.event.dx = 0;
> -        de.u.event.dy = 0;
> +        de.u.event.dx = event->dx;
> +        de.u.event.dy = event->dx;

The above assignment looks pretty suspicious to me.

>          de.u.event.screen = pScreen->myNum;
>          de.u.event.state = ev.corestate;
>  
> @@ -1120,8 +1120,8 @@ DGAProcessPointerEvent (ScreenPtr pScreen, DGAEvent *event, DeviceIntPtr mouse)
>          de.u.u.type = *XDGAEventBase + coreEquiv;
>          de.u.u.detail = event->detail;
>          de.u.event.time = event->time;
> -        de.u.event.dx = 0;
> -        de.u.event.dy = 0;
> +        de.u.event.dx = event->dx;
> +        de.u.event.dy = event->dx;
>          de.u.event.screen = pScreen->myNum;
>          de.u.event.state = ev.corestate;
>  
> -- 
> 1.7.3.4
> 
> _______________________________________________
> xorg-devel at lists.x.org: X.Org development
> Archives: http://lists.x.org/archives/xorg-devel
> Info: http://lists.x.org/mailman/listinfo/xorg-devel