[PATCH 2/2] xfree86/modes: Make cursor position transform a helper function

Aaron Plattner aplattner at nvidia.com
Thu Aug 25 17:32:36 PDT 2011


On Thu, Aug 25, 2011 at 04:54:41PM -0700, Keith Packard wrote:
> On Thu, 25 Aug 2011 16:35:10 -0700, Aaron Plattner <aplattner at nvidia.com> wrote:
> 
> > When the driver can handle the crtc transform in hardware, it sets
> > crtc->driverIsPerformingTransform, which turns off both the shadow
> > layer and the cursor's position-transforming code.  However, some
> > drivers actually do require the cursor position to still be
> > transformed in these cases.  Move the cursor position transform into a
> > helper function that can be called by such drivers.
> 
> What about the cursor image? Do we need separate control over that as
> well?

Tegra rotates the whole screen after compositing the cursor, so we
actually don't want the cursor image rotated when we're handling the
rotation.  I'm assuming other hardware's rotation works the same way,
so I'd be surprised if other drivers would want the image rotated when they
set driverIsHandlingTransform.  It wouldn't be too hard to add a helper
function to do it, or just do it in the drivers.

For other transforms, the cursor image isn't transformed by the server
anyway.

-- Aaron


More information about the xorg-devel mailing list