[PATCH] dix: Use event conversion routines in EventIsDeliverable

Peter Hutterer peter.hutterer at who-t.net
Wed Aug 10 17:19:35 PDT 2011


On Tue, Aug 09, 2011 at 08:48:36PM -0700, Keith Packard wrote:
> On Wed, 10 Aug 2011 12:56:32 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> 
> > Proximity events don't have an XI2 type and caused error messages in the
> > log when trying to get the event filter. Use this opportunity to clean up
> > the code, instead of manually setting the fields that GetEventFilter
> > requires use EventTo(XI2|XI|Core) instead.
> 
> Seems like this would look neater if it wasn't allocating events just to
> be able to use the GetEventFilter function.
> 
> This is on top of your patch; I haven't tested it at all, but does it
> look like a reasonable thing to do?

yes, I agree. I take your patch and raise you another one (on top of both).
Looking at the diff of those three together, the code is much easier to
follow now too. Though I might split up the patches to introduce the
functions first and then replace the EventIsDeliverable() code to fix the
original bug, I'll send out a separate sequence for this.



More information about the xorg-devel mailing list