[PATCH] randr: stop clients from deleting immutable output properties

[Luc Verhaegen]

On Wed, Aug 10, 2011 at 03:28:37PM +0100, Daniel Stone wrote:
> On Wed, Aug 10, 2011 at 03:53:03PM +0200, Luc Verhaegen wrote:
> > On Wed, Aug 10, 2011 at 03:48:30PM +0200, Luc Verhaegen wrote:
> > > This was not done for a few reasons:
> > > 1) it clearly splits between clientside and server internal usage. The 
> > > comment that i added to RRDeleteOutputProperty in the very first version
> > > of the patch underlined that this was only for server internal use due
> > > to immutable (this was the code tested on the N9, but was never 
> > > committed).
> > > 2) ValidAtom is only ever called in the client side functions, while
> > > the check for immutable is once in general and once in client side,
> > > putting the balance client side, so i picked client side.
> > > 3) it is much more invasive.
> > 
> > Not that it really matters either way, i just felt that the other had a 
> > higher probability of being accepted as is, as any of the above three
> > reasons could've been cited for going for the smaller patch.
> 
> *shrug*, I'm not the RandR maintainer, but it just seemed a bit daft to
> inline an entire function just to add one check in the middle.

In the first approximation, sure.

Luc Verhaegen.