[PATCH] randr: stop clients from deleting immutable output properties

[Luc Verhaegen]

On Wed, Aug 10, 2011 at 03:48:30PM +0200, Luc Verhaegen wrote:
> On Wed, Aug 10, 2011 at 01:44:57PM +0100, Daniel Stone wrote:
> > On Wed, Aug 10, 2011 at 01:06:33PM +0200, Luc Verhaegen wrote:
> > > Immutable in randr means that clients are not able to alter the
> > > property itself, they are only allowed to alter the property value.
> > > This logically means that the property then should not be deleted
> > > by the client either.
> > 
> > Instead of inlining RRDeleteOutputProperty here, you could do something
> > like this.
> > 
> > Cheers,
> > Daniel
> 
> This was not done for a few reasons:
> 1) it clearly splits between clientside and server internal usage. The 
> comment that i added to RRDeleteOutputProperty in the very first version
> of the patch underlined that this was only for server internal use due
> to immutable (this was the code tested on the N9, but was never 
> committed).
> 2) ValidAtom is only ever called in the client side functions, while
> the check for immutable is once in general and once in client side,
> putting the balance client side, so i picked client side.
> 3) it is much more invasive.
> 
> Luc Verhaegen.

Not that it really matters either way, i just felt that the other had a 
higher probability of being accepted as is, as any of the above three
reasons could've been cited for going for the smaller patch.

Luc Verhaegen.