xf86-video-geode: Changes to 'master'

Julien Cristau jcristau at debian.org
Wed Sep 29 06:56:39 PDT 2010


On Wed, Sep 29, 2010 at 06:36:52 -0700, Martin-Éric Racine wrote:

>  src/lx_output.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> New commits:
> commit 89c60efe899f0cda4a52e0574f030c021c4b1ece
> Author: Frank Huang <frankr.huang at amd.com>
> Date:   Wed Sep 29 16:35:46 2010 +0300
> 
>     Mode Validation support on modeline in xorg.conf
>     
>     *mode validation(lx_output_mode_valid) in this driver should return MODE_OK for
>     all modes filtered out by previous process in this function. Otherwise, new
>     modelines(conf_modes) will be pruned by Xserver function Xf86PruneInvalidModes.
>     The result is that the user can not set arbitrary resolutions. We comply with
>     the code of ATI&&Intel mode_valid function to do this.
>     *For modes that cannot be supported by the geode driver, it is better to give
>     the specific MODE_XXX(such as MODE_CLOCK_RANGE) instead of MODE_BAD.
>     
>     Signed-off-by: Frank Huang <frankr.huang at amd.com>
> 
This looks broken.  lx_output_mode_valid() now returns MODE_OK for every
possible mode, but takes great pains to get there.  The commit message
doesn't help, I have no idea what it's trying to say.

Cheers,
Julien


More information about the xorg-devel mailing list