[PULL] tables initialization and DISPATCH_PROC usage removal

Vignatti Tiago (Nokia-MS/Helsinki) tiago.vignatti at nokia.com
Mon Sep 27 09:49:29 PDT 2010


On Fri, Sep 24, 2010 at 12:25:06AM +0200, ext Keith Packard wrote:
> On Tue, 14 Sep 2010 20:50:48 +0300, Tiago Vignatti <tiago.vignatti at nokia.com> wrote:
> 
> > Although there are two commits only in this set without functional changes,
> > they touch quite a lot of code, so I preferred to send to you soon before they
> > get outdated again :)
> 
> Perhaps they're already stale?
> 
> xcmisc.c:202: warning: no previous prototype for ‘XCMiscExtensionInit’
>   CC     shm.lo
>   CC     panoramiX.lo
> shm.c: In function ‘ProcPanoramiXShmPutImage’:
> shm.c:555: warning: implicit declaration of function ‘ProcShmPutImage’
> shm.c:555: warning: nested extern declaration of ‘ProcShmPutImage’
> shm.c: In function ‘ProcPanoramiXShmGetImage’:
> shm.c:589: warning: implicit declaration of function ‘ProcShmGetImage’
> shm.c:589: warning: nested extern declaration of ‘ProcShmGetImage’
> shm.c: At top level:
> shm.c:801: error: static declaration of ‘ProcShmPutImage’ follows non-static declaration
> shm.c:555: note: previous implicit declaration of ‘ProcShmPutImage’ was here
> shm.c:911: error: static declaration of ‘ProcShmGetImage’ follows non-static declaration
> shm.c:589: note: previous implicit declaration of ‘ProcShmGetImage’ was here

arrgh, same problem I had some time ago - didn't compile with xinerama
support.

I moved two functions ahead and amend such fix in the first patch. Can you
please pull it again? I rebased on the top of current master:

    git://people.freedesktop.org/~vignatti/xserver.git tables-cleanup


Thanks,
             Tiago


More information about the xorg-devel mailing list