libXt-1.0.8: fix dereferenc in TMprint.c

walter harms wharms at bfs.de
Wed Sep 22 10:25:20 PDT 2010


hi list;
the current codes checks for
 eventWidget == NULL after accessing
eventWidget->core.tm.proc_table

now it checks for eventWidget before access eventWidget->core.tm.proc_table.


The org. patch is attacehd since i guess the tabs will be mangeld.

re,
 wh

Signed-off-by: walter harms <wharms at bfs.de>

--- libXt-1.0.8/src/TMprint.c.org       2010-09-21 23:42:08.000000000 +0200
+++ libXt-1.0.8/src/TMprint.c   2010-09-21 23:44:44.000000000 +0200
@@ -782,12 +782,16 @@
     PrintRec           stackPrints[STACKPRINTSIZE];
     PrintRec           *prints;
     TMShortCard                numPrints, maxPrints;
-    TMBindData bindData = (TMBindData) eventWidget->core.tm.proc_table;
+    TMBindData bindData ;
     TMComplexBindProcs complexBindProcs;

     if ((eventWidget == NULL) ||
-       ((xlations = eventWidget->core.tm.translations) == NULL) ||
-       (bindData->simple.isComplex == False))
+       (eventWidget->core.tm.translations == NULL) )
+      return;
+
+    xlations = eventWidget->core.tm.translations;
+    bindData = (TMBindData) eventWidget->core.tm.proc_table;
+    if (bindData->simple.isComplex == False)
       return;

     sb->current = sb->start = __XtMalloc((Cardinal)1000);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: deref.patch
Type: text/x-diff
Size: 847 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100922/ec0727bc/attachment-0001.patch>


More information about the xorg-devel mailing list