[PATCH 3/9] vgahw: Move IO domain setup to IO dispatch vector setup

Adam Jackson ajax at redhat.com
Wed Sep 22 08:27:18 PDT 2010


On Tue, 2010-09-21 at 16:42 -0700, Alan Coopersmith wrote:
> Adam Jackson wrote:
> > Signed-off-by: Adam Jackson <ajax at redhat.com>
> > ---
> >  hw/xfree86/vgahw/vgaHW.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/hw/xfree86/vgahw/vgaHW.c b/hw/xfree86/vgahw/vgaHW.c
> > index 7f0ad28..ef17f4a 100644
> > --- a/hw/xfree86/vgahw/vgaHW.c
> > +++ b/hw/xfree86/vgahw/vgaHW.c
> > @@ -356,6 +356,8 @@ vgaHWSetStdFuncs(vgaHWPtr hwp)
> >      hwp->PIOOffset		= 0;
> >      hwp->readEnable		= stdReadEnable;
> >      hwp->writeEnable		= stdWriteEnable;
> > +
> > +    hwp->PIOOffset = scrp->domainIOBase;
> >  }
> 
> Is there some reason you didn't update the hwp->PIOOffset = 0; that's
> a few lines earlier instead?

Just didn't see it.  But that field goes away in the port to pciaccess
so it's a bit moot.

- ajax
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100922/5d69665e/attachment.pgp>


More information about the xorg-devel mailing list