[PATCH 0/8] Yet more loader cleanups

Adam Jackson ajax at redhat.com
Tue Sep 21 16:05:18 PDT 2010


Largely cosmetic cleanups.  Removes a few layers of abstraction that
resulted in double-tracking reference counts and other such hilarity.
I think it ends up being approximately equivalent in terms of heap
usage, since it requires keeping track of the loaded module path in
case you ever call DuplicateModule on it... and you do.  I have a
plan for eliminating that too but it's not going to be quite as easy.

The "unused refcounting from input drivers" commit is technically at
least an API break and possibly an ABI break for input, but not in
any way that seems to matter.  I started the server and evdev worked
without a rebuild, so.

---

The following changes since commit c768cdda92696b636c10bb2df64167d5274b4b99:

  Merge remote branch 'jamey/reviewed' (2010-09-13 16:48:33 -0700)

are available in the git repository at:

  ssh://people.freedesktop.org/~ajax/xserver.git less-loader

Adam Jackson (8):
      loader: Merge dlloader directly into the loader
      loader: Remove unused module serial number
      loader: Remove unused canonical name field
      loader: Remove the handle field from LoaderOpen
      loader: include cleanup
      loader: Remove a silly layer of reference counting
      xfree86: Remove unused refcounting from input drivers
      xfree86: Remove useless module setup functions where appropriate

 hw/xfree86/common/xf86Helper.c     |    5 -
 hw/xfree86/common/xf86Xinput.h     |    1 -
 hw/xfree86/fbdevhw/fbdevhw.c       |   10 +--
 hw/xfree86/i2c/bt829_module.c      |    9 +--
 hw/xfree86/i2c/fi1236_module.c     |    9 +--
 hw/xfree86/i2c/msp3430_module.c    |    9 +--
 hw/xfree86/i2c/tda8425_module.c    |    9 +--
 hw/xfree86/i2c/tda9850_module.c    |    9 +--
 hw/xfree86/i2c/tda9885_module.c    |    9 +--
 hw/xfree86/i2c/uda1380_module.c    |    9 +--
 hw/xfree86/int10/xf86int10module.c |   23 +----
 hw/xfree86/loader/Makefile.am      |    2 -
 hw/xfree86/loader/dlloader.c       |  178 ----------------------------------
 hw/xfree86/loader/dlloader.h       |   33 ------
 hw/xfree86/loader/loader.c         |  188 +++++++++---------------------------
 hw/xfree86/loader/loader.h         |   23 +----
 hw/xfree86/loader/loaderProcs.h    |    5 +-
 hw/xfree86/loader/loadmod.c        |   79 +++++++--------
 hw/xfree86/vbe/vbe_module.c        |   10 +--
 19 files changed, 98 insertions(+), 522 deletions(-)
 delete mode 100644 hw/xfree86/loader/dlloader.c
 delete mode 100644 hw/xfree86/loader/dlloader.h

---

- ajax



More information about the xorg-devel mailing list