[PATCH 2/3] os: remove useless smart scheduler macros

Vignatti Tiago (Nokia-MS/Helsinki) tiago.vignatti at nokia.com
Thu Sep 9 08:38:09 PDT 2010


On Thu, Sep 09, 2010 at 05:17:45PM +0200, ext Jon TURNEY wrote:
> On 09/09/2010 09:01, Vignatti Tiago (Nokia-MS/Helsinki) wrote:
> > On Tue, Sep 07, 2010 at 06:02:32PM +0200, ext Jon TURNEY wrote:
> >> On 07/09/2010 13:39, Tiago Vignatti wrote:
> >>> Signed-off-by: Tiago Vignatti<tiago.vignatti-xNZwKgViW5gAvxtiuMwx3w at public.gmane.org>
> >>> ---
> >>>    os/utils.c |   21 ++-------------------
> >>>    1 files changed, 2 insertions(+), 19 deletions(-)
> >>>
> >>> diff --git a/os/utils.c b/os/utils.c
> >>> index 547acfc..bf3d615 100644
> >>> --- a/os/utils.c
> >>> +++ b/os/utils.c
> >>> @@ -1116,17 +1116,9 @@ XNFstrdup(const char *s)
> >>>        return ret;
> >>>    }
> >>>
> >>> -
> >>> -#define SMART_SCHEDULE_POSSIBLE
> >>> -#ifdef SMART_SCHEDULE_POSSIBLE
> >>> -#define SMART_SCHEDULE_SIGNAL		SIGALRM
> >>> -#define SMART_SCHEDULE_TIMER		ITIMER_REAL
> >>> -#endif
> >>
> >> I'm afraid that we always disable SMART_SCHEDULE_POSSIBLE on cygwin, as a
> >> server built with the smart scheduler enabled doesn't work very well, probably
> >> due to some poorly understood bug in the cygwin signal emulation code.
> >>
> >> So, please don't do this.
> >
> > can you please clarify this and try to understand what's the real reason for
> > cygwin do not work with SmartScheduleDisable (-dumbSched) set?
> 
> Sorry, I had misunderstood your patch.  As long as I can patch to make 
> -dumbSched the default, there is no problem, so go ahead.

all right, thanks for checking it Jon. Do you care to sign this patch series
please?


Thank you,
             Tiago


More information about the xorg-devel mailing list