[PATCH 02/19] Remove atom field from InputInfoRec.

Peter Hutterer peter.hutterer at who-t.net
Tue Sep 7 15:42:09 PDT 2010


On Tue, Sep 07, 2010 at 01:40:49PM -0700, Alan Coopersmith wrote:
> Peter Hutterer wrote:
> > This field was only used in one location where we can use a local variable.
> > -    Atom		    atom;
> 
> The mouse & vmmouse drivers seem to use this in a debug message that would
> need to be fixed:
> 
> #ifdef EXTMOUSEDEBUG
>         ErrorF("assigning %p atom=%d name=%s\n", device, pInfo->atom,
>                 pInfo->name);
> #endif
> 
> but that's the only use I see in a quick grep of the xf86-input-* I have
> local copies of.

some of the fields removed are initialized to zero by the drivers (e.g.
wacom did this to old_x/old_y). I'll update those of course in those drivers
that are still alive.

> Reviewed-by: Alan Coopersmith <alan.coopersmith at oracle.com>

thanks!

Cheers,
  Peter


More information about the xorg-devel mailing list