[PATCH app-xdm 18/19] config: replace platform check with compiler defines for SU

Alan Coopersmith alan.coopersmith at oracle.com
Thu Sep 2 13:03:20 PDT 2010


Mark Kettenis wrote:
>> From: Gaetan Nadon <memsize at videotron.ca>
>> Date: Thu, 02 Sep 2010 12:57:22 -0400
>>
>> The intent for the platform check for SU is to use "su -m" for
>> BSD-like systems. The compiler already provide defines for
>> such systems.
> 
> Not sure this is progress.  Generally people want to move away from
> #ifdef's and move to putting checks in the configure script instead of
> the other way around.

Ideally we'd figure out some way to test for -m support, instead of having
to keep track of the set of uname values or preprocessor defines that
currently represent OS'es with a BSD-like userland (while new BSD distros
don't spring up as often as new Linux distros, it is still a pain every
few years to go find all the places to add "|| dragonfly" or whatever the
next new one will be, and the hybrids like GNU/kFreeBSD confuse things
even more).

Unfortunately, I can't think of a good way to test su functionality in
a configure script.   I wonder if it would be better to replace use of
su in the xdm-config with code to setuid before running the *.willing
script, to a userid specified in a new option in the xdm-config.

-- 
	-Alan Coopersmith-        alan.coopersmith at oracle.com
	 Oracle Solaris Platform Engineering: X Window System



More information about the xorg-devel mailing list