[PATCH] silent: Set AM_DEFAULT_VERBOSITY for compatibility on older automake

Gaetan Nadon memsize at videotron.ca
Sat Feb 27 12:53:10 PST 2010


On Sat, 2010-02-27 at 11:32 -0800, Dan Nicholson wrote:

> Custom silent rules will become recursive on older automake where
> AM_SILENT_RULES is not included. Set AM_DEFAULT_VERBOSITY in this
> fallback case for compatibility.
> 
> Signed-off-by: Dan Nicholson <dbn.lists at gmail.com>
> ---
>  I hit this error in xts when a couple people tried to run the test
>  suite against older hosts.
> 
>  xorg-macros.m4.in |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
> index 7ba0c9a..478e5fe 100644
> --- a/xorg-macros.m4.in
> +++ b/xorg-macros.m4.in
> @@ -935,7 +935,8 @@ XORG_RELEASE_VERSION
>  XORG_CHANGELOG
>  XORG_INSTALL
>  XORG_MANPAGE_SECTIONS
> -m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])])
> +m4_ifdef([AM_SILENT_RULES], [AM_SILENT_RULES([yes])],
> +    [AC_SUBST([AM_DEFAULT_VERBOSITY], [1])])
>  ]) # XORG_DEFAULT_OPTIONS
>  
>  # XORG_INSTALL()


Reviewed-by: Gaetan Nadon <memsize at videotron.ca>

Out of curiosity, how old an Automake are we talking about? Our minimum
is 1.9 (latest is 1.9.6) which works fine. 







-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100227/10e0eb98/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100227/10e0eb98/attachment.pgp>


More information about the xorg-devel mailing list