[PATCH 2/2] Allow for missing or disabled compat_output

Keith Packard keithp at keithp.com
Thu Feb 25 12:46:16 PST 2010


On Thu, 25 Feb 2010 15:16:47 -0500, Adam Jackson <ajax at nwnk.net> wrote:

> This bit is really lame.  compat_output never changes for the life of
> the server;

Yes, it can. SetCompatOutput is called every time a client asks for the
current RandR mode list.

> if you've turned off what the server picked for compat at
> startup, vidmode gamma won't change anything.  Picking the first crtc
> with a connected output in this case is slightly more DWIMmy, I guess.

Yeah, but we still need to deal with the case of no outputs having a
crtc, which can happen if you close the lid on a laptop.

> But on the other hand: stop using vidmode already, dammit.

Agreed. We do have alternate APIs now. Thanks, xscreensaver.

> Reviewed-by: Adam Jackson <ajax at redhat.com>

Thanks!

I'll push this to master; it'd be great to hear whether this fixes other
people's issues...

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100225/ab3971a6/attachment.pgp>


More information about the xorg-devel mailing list