xkb: Switch delay to a group

Dirk Wallenstein halsmit at t-online.de
Thu Feb 4 08:24:52 PST 2010


On Thu, 04 Feb 2010 18:15:00 +0300 Ilya Murav'jov wrote:
> > The thing is, and I guess you have seen that, is that the handlers are
> > missing the differentiation between Press/Release altogether. If you
> > could fix that you can use XkbFilterRec to store a flag. I think just
> > going more global is not the right thing to do here.
>
> Well, I considered to set up another filter via XkbFilterRec and
> _XkbApplyFilters() but xkbi->filters is a vector. If one need to cancel
> the delay switching then the vector have to be gone all round to
> deactivate the filter. I think another flag in xkbi->state is more natural.

That's the wonderful thing about xkbActions.c. The filter system has to
be rewritten, too - it needs per-level granularity. Maybe there can be a
more general approach towards canceling actions when doing that.

But maybe you would want to put the focus on switch-group-on-release
first. If want to try it without Press/Release knowledge inside the
handler you might want to try to skip the first event. If that works
together with an option to select between when to trigger the switch
(press/release), that would be an improvement already.

Greetings, Dirk


More information about the xorg-devel mailing list