[PULL] misc XQuartz fixes

Keith Packard keithp at keithp.com
Fri Apr 30 12:44:44 PDT 2010


On Tue, 27 Apr 2010 13:23:26 -0700, Jeremy Huddleston <jeremyhu at apple.com> wrote:

> This pull request includes an unreviewed patch outside of XQuartz
> which has been submitted to the list twice.  It is small and just adds
> some sanity checking to miPaintWindow.  These checks used to be in
> XQuartz' paintWindow() codepath before all that was nuked.  It helps
> us make sure we don't try to draw the root window when it shouldn't be
> drawn (rootless mode).

Ok, 'drawable' will never be null -- it's assigned as a reference to the
drawable element inside the window structure.

Second, if it's really just for rootless mode, then shouldn't the check
be stuck inside the nice ROOTLESS block sitting there?

-- 
keith.packard at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.x.org/archives/xorg-devel/attachments/20100430/771310b6/attachment.pgp>


More information about the xorg-devel mailing list