[PULL] MAXSCREENS removal preparation

Aaron Plattner aplattner at nvidia.com
Mon Apr 26 09:27:56 PDT 2010


On Mon, Apr 26, 2010 at 05:29:16AM -0700, Tiago Vignatti wrote:
> Keith,
>
> This patch series is a preparation to remove MAXSCREENS from the server. It
> shouldn't affect nothing so in depth, really. Just a preparation.
>
> Before go to remove MAXSCREENS, there will be probably one more one
> preparation set including xinerama patches from Jamey (I still have to review
> them) and some xvfb fixes that I sent a week ago. That's in my backlog.
>
> On the top of this patch series there's a single patch to remove "unused"
> fields and bump the ABI. This one is not reviewed by no one yet, but I guess
> you can choose by yourself if it goes or not.
>
> The work is here:
>
>     git://people.freedesktop.org/~vignatti/xserver.git for-keith
>
>
> Please, let me know if everything looks good. Thanks
>
>            Tiago
>
>
> The following changes since commit 35d208125fa0ec78e8d694adc52886b977e789cf:
>   Tiago Vignatti (1):
>         xfree86: fix not reached code in fi1236 driver from i2c
>
> are available in the git repository at:
>
>   git://people.freedesktop.org/~vignatti/xserver.git for-keith
>
> Jamey Sharp (3):
>       xfree86: use screen privates for Xv offscreen images.

Why does xf86XVRegisterOffscreenImages call dixRequestPrivate every time,
with a constant size?  You should be able to call it in, say,
xf86XVScreenInit and just rely on dixLookupPrivate to allocate the
requested size for you.

>       xfree86: use screen privates for exclusive DGA clients

Can we ditch DGAClientPrivateKey and combine the two DGA keys into one?
I'm worried that we're going to hit PRIV_MAX (currently 256) soon.

Speaking of that, we should probably increase PRIV_MAX or make it dynamic
somehow if we're going to move a lot of stuff to devPrivates.

>       fb: track screens' installed colormaps as screen privates.
>
> Jon TURNEY (2):
>       Xwin: Simplify screen option processing
>       Xwin: make screens structures run-time adjustable
>
> Tiago Vignatti (5):
>       mi: track screens' installed colormaps as screen privates
>       xfree86: track screens' installed colormaps as screen privates
>       xfree86: no need to assign numScreens again
>       dix and others: remove unused arraySize field from ScreenInfo
>       include: remove couple of unused structures fields and bump ABI

Bleh @ gratuitous ABI changes, but whatever.


More information about the xorg-devel mailing list