[PATCH 5/5] xkb: rename XkbFakeDeviceButton and XkbFakeDeviceMotion, move into xkbActions.c

Dan Nicholson dbn.lists at gmail.com
Fri Apr 16 09:11:25 PDT 2010


On Wed, Apr 14, 2010 at 11:08:14AM +1000, Peter Hutterer wrote:
> The name XkbDDXFakeDeviceButton and XkbDDXFakeDeviceMotion is somewhat
> misleading, there's no DDX involved in the game at all anymore.
> 
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  include/xkbsrv.h |   13 -------
>  xkb/Makefile.am  |    4 +--
>  xkb/ddxDevBtn.c  |   69 --------------------------------------
>  xkb/ddxFakeMtn.c |   64 -----------------------------------
>  xkb/xkbActions.c |   97 ++++++++++++++++++++++++++++++++++++++++++++++-------
>  5 files changed, 85 insertions(+), 162 deletions(-)
>  delete mode 100644 xkb/ddxDevBtn.c
>  delete mode 100644 xkb/ddxFakeMtn.c
> 
> diff --git a/include/xkbsrv.h b/include/xkbsrv.h
> index 239b7a1..a5d25d0 100644
> --- a/include/xkbsrv.h
> +++ b/include/xkbsrv.h
> @@ -768,19 +768,6 @@ extern _X_EXPORT void XkbDDXUpdateDeviceIndicators(
>  	CARD32			/* newState */
>  );
>  
> -extern _X_EXPORT void XkbDDXFakePointerMotion(
> -	DeviceIntPtr	/* dev */,
> - 	unsigned int	/* flags */,
> -	int		/* x */,
> -	int		/* y */
> -);
> -
> -extern _X_EXPORT void XkbDDXFakeDeviceButton(
> -	DeviceIntPtr	/* dev */,
> -	Bool		/* press */,
> -	int		/* button */
> -);
> -

Does it matter that these are removed from the API? I don't think a driver
would want to send a fake event, but it might be best to justify their
removal in the commit message.

Otherwise, seems like a nice cleanup.

Reviewed-by: Dan Nicholson <dbn.lists at gmail.com>


More information about the xorg-devel mailing list