[PATCHv2 2/2] glx: Drop DestroyWindow hook

Kristian Høgsberg krh at bitplanet.net
Thu Apr 15 04:58:06 PDT 2010


2010/4/15 Michel Dänzer <michel at daenzer.net>:
> On Wed, 2010-04-14 at 15:13 -0400, Kristian Høgsberg wrote:
>>
>> The real fix is the patch from attachment 25038, not the DestroyWindow
>> hook.  If the context is destroyed first, it will remove itself from
>> the glxAllContexts list so the DrawableGone destructor won't touch it.
>>  On the other hand, if the drawable is destroyed first, thanks to your
>> patch, it will detach itself from the context properly so context
>> destruction (whether at resource cleanup time or at client shutdown
>> time) wont touch a free drawable.
>
> Right, but that will only work if DestroyWindow of the X window also
> destroys the corresponding GLX drawable. Are you saying that's
> guaranteed anyway now, and have you tested that none of MacSlow's
> rgba-glx demos crashes the X server on exit anymore without this hook?

Yes, the GLX drawable is a client allocated resource that gets cleaned
up when the client exits.  The rgba-glx demo exits nicely without
crashing the X server with this and the 1/2 patch to convert DRI2
drawables to resources.

Kristian


More information about the xorg-devel mailing list