[PATCH 1/5] dix: make MAXSCREENS run-time configurable

Aaron Plattner aplattner at nvidia.com
Thu Apr 8 12:24:41 PDT 2010


On Thu, Apr 08, 2010 at 08:06:33AM -0700, Tiago Vignatti wrote:
> diff --git a/Xext/panoramiX.c b/Xext/panoramiX.c
> index cfeba01..7d1b849 100644
> --- a/Xext/panoramiX.c
> +++ b/Xext/panoramiX.c
> @@ -122,7 +122,7 @@ typedef struct {
>    CloseScreenProcPtr   CloseScreen;
>  } PanoramiXScreenRec, *PanoramiXScreenPtr;
> 
> -RegionRec XineramaScreenRegions[MAXSCREENS];
> +RegionRec *XineramaScreenRegions;

Since you're breaking the ABI already, could we move this sort of
dynamically-allocated global array into the pScreen or pScrnInfo instead,
either as just a plain old struct member or as a DevPrivate hook?  That
will get us one step closer to completely dynamically allocated screens.

-- Aaron


More information about the xorg-devel mailing list