[PATCH] Add configuration option for use of SIGIO handlers for input events
Peter Hutterer
peter.hutterer at who-t.net
Mon Sep 14 21:01:35 PDT 2009
On Mon, Sep 14, 2009 at 10:48:56AM -0700, Alan Coopersmith wrote:
> Peter Hutterer wrote:
> > Any comments on the use of different names for the same thing? (maybe you
> > missed that in the previous email)
>
> Oops, yes, I'd missed that.
>
> > Cut from this patch:
> >> +SIGIO_DEFAULT="yes"
> >> +AC_ARG_ENABLE(sigio-default, AS_HELP_STRING([--enable-sigio-default]
> >> + SIGIO_DEFAULT_VALUE=TRUE
> >> + FLAG_USE_SIGIO
> >> + if (!xf86Info.useSIGIO) {
> >> +.BI "Option \*qUseSIGIO\*q \*q" boolean \*q
> >
> > IMO we should use USE_SIGIO in configure.ac as well if that is the one
> > exposed in the xorg.conf.
>
> I was trying to expose that it was the default value for UseSIGIO, that
> configure sets, not disabling the build of the SIGIO code altogether.
I think having "use" in the flag indicates this already but I can see your
point.
> Would USE_SIGIO_DEFAULT make sense? What about the --enable option?
USE_SIGIO_BY_DEFAULT and --enable-use-sigio-by-default
clumsy, but I can't come up with anything better.
Cheers,
Peter
More information about the xorg-devel
mailing list