wheel emulation broken in recent evdev

[Daniel Stone]

On Sat, Sep 19, 2009 at 04:28:55PM -0400, Andy Neitzke wrote:
> On my system (Thinkpad X60t, Gentoo amd64) wheel emulation was broken by 
> commit f4ba2bd785b25fd522967abd7775925d5fded70f ("Allow 0 as wheel emulation 
> button for unconditional scrolling (#20529)").
> 
> A little experimenting here suggests the problem is that this commit 
> incidentally replaced
> 
> int ms;
> ms = pEvdev->emulateWheel.expires - GetTimeInMillis();
> if (ms > 0)
> 
> by
> 
> if (pEvdev->emulateWheel.expires - GetTimeInMillis() > 0)
> 
> I don't know why the two aren't equivalent -- something to do with signed 
> versus unsigned integers?

I believe this is fixed now, right?

Cheers,
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : http://lists.x.org/archives/xorg-devel/attachments/20091004/75a330b8/attachment.pgp