[PATCH] Define per-output DPMS protocol

Peter Hutterer peter.hutterer at who-t.net
Fri Jun 12 05:41:49 PDT 2009


just a few minor cosmetic changes:

On Thu, Jun 11, 2009 at 05:13:41PM -0400, Adam Jackson wrote:
> @@ -1240,6 +1250,29 @@ dynamic changes in the display environment.
>  
>  	RRGetOutputPrimary returns the primary output for the screen.
>  
> +7.3. Extension Requests added in version 1.4 of the extension
> +
> +┌───
> +    RRSetOutputDPMS
> +	output: OUTPUT
> +	level: DPMSLEVEL
> +└───
> +	Errors: Output, Value
> +
> +	RRSetOutputDPMS sets the DPMS state of 'output' to 'mode'.

i think this should be s/mode/level/

>  11.1 XFree86-VidModeExtension
>  
> @@ -1624,6 +1657,23 @@ re-querying the configuration with the Xinerama extension will get updated
>  information. It is probably better to view RandR as a superset of Xinerama
>  at this point and use it in preference to Xinerama where both are present.
>  
> +11.3 DPMS
> +
> +The DPMS extension's controls effectively apply the requested DPMS level to
> +all outputs on all screens.  This includes both timeout-triggered
> +transitions, and forced DPMS level.  The DPMS extension's query interface

"the forced DPMS level" or "forced DPMS levels". 
also, no comma before 'and' here but that's being anal.

> +A.2.3 Protocol Requests added with version 1.4
> +
> +┌───
> +    RRSetOutputDPMS
> +	1	CARD8			major opcode
> +	1	32			RandR opcode
> +	2	3			length
> +	4	OUTPUT			output
> +	4	DPMSLEVEL		level
> +└───
> +    
> +┌───
> +    RRGetOutputDPMS
> +	1	CARD8			major opcode
> +	1	33			RandR opcode
> +	2	2			length
> +	4	OUTPUT			output
> +      ▶
> +	1	1			Reply
> +	1				unused
> +	2	CARD16			sequence number
> +	4	CARD32			length
> +	4	DPMSLEVEL		level
> +	4	CARD32			pad1
> +	4	CARD32			pad2
> +	4	CARD32			pad3
> +	4	CARD32			pad4
> +└───
> +

this is probably in line with the rest of the document but it seems odd to
specify the length of the request (2) but just CARD32 for the length in the
reply (instead of 0). especially since the first 8 bytes (including the
length field) in the reply are fixed anyway.

Cheers,
  Peter


More information about the xorg-devel mailing list