[PATCH 1/4] Hide a number of private symbols

Mark Kettenis mark.kettenis at xs4all.nl
Fri Jul 31 05:06:39 PDT 2009


> From: Julien Cristau <jcristau at debian.org>
> Date: Fri, 31 Jul 2009 13:49:39 +0200
> 
> Add _X_HIDDEN for some symbols that aren't used outside of Xlib.
> Make _XKeyInitialize static (with the associated code movement inside
> src/KeyBind.c)

> +#ifdef XKB
> +_X_HIDDEN
> +#endif
> +KeySym
> +XKeycodeToKeysym(Display *dpy,

I don't think it is a good idea to hide symbols based on #ifdefs like
that.  It's very easy to mess up the X11 ABI this way.



More information about the xorg-devel mailing list