[PATCH] xserver-1.6: Fix keyboard repeat problem

[Kim Woelders]

On Thu, 16 Jul 2009 07:04:35 +0200, Peter Hutterer  
<peter.hutterer at who-t.net> wrote:

> On Mon, Jul 13, 2009 at 04:52:22PM +0200, Kim Woelders wrote:
>> I have had trouble with keys getting "stuck" and autorepeating until  
>> some
>> key press. I believe the problem is related to clients grabbing the
>> keyboard for some(?) time. The attached patch seems to cure this.
>>
>> I have only seen the problem in xserver 1.6, not 1.5 or master.
>>
>> /Kim
>
>> From 35dcb78d84261efb591cccef5271f424bea0cf7e Mon Sep 17 00:00:00 2001
>> From: Kim Woelders <kim at woelders.dk>
>> Date: Sat, 11 Jul 2009 18:55:17 +0200
>> Subject: [PATCH] Fix key repeat problem.
>>
>>
>> Signed-off-by: Kim Woelders <kim at woelders.dk>
>> ---
>>  dix/events.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/dix/events.c b/dix/events.c
>> index f15c460..5388a16 100644
>> --- a/dix/events.c
>> +++ b/dix/events.c
>> @@ -1161,7 +1161,7 @@ EnqueueEvent(xEvent *xE, DeviceIntPtr device, int  
>> count)
>>  #ifdef XKB
>>      /* Fix for key repeating bug. */
>>      if (device->key != NULL && device->key->xkbInfo != NULL &&
>> -	xE->u.u.type == KeyRelease)
>> +	(xE->u.u.type == KeyRelease || xE->u.u.type == DeviceKeyRelease))
>>  	AccessXCancelRepeatKey(device->key->xkbInfo, xE->u.u.detail);
>>  #endif
>>
>> --
>> 1.6.3.3
>
> ACK.
>
> Looks sane, though I haven't noticed this problem myself (mostly running  
> on master
> though).
>
Thanks. Would anybody care to commit this?

/Kim