[PATCH] dri2: Preserve compatibility with 1.6 DRI2 API/ABI

Silvio Frischknecht silvio.frischi at gmail.com
Mon Jul 6 03:13:27 PDT 2009


The first I hope I got the reply thing right. quite tricky to reply to a mail 
you never got. :D

Then the patch has has a bug.

--- a/hw/xfree86/dri2/dri2.h
+++ b/hw/xfree86/dri2/dri2.h
@@ -35,16 +35,27 @@
 
 #include <X11/extensions/dri2tokens.h>
 
+/* Version 1 structure (for ABI compatibility) */
 typedef struct {
     unsigned int attachment;
     unsigned int name;
     unsigned int pitch;
     unsigned int cpp;
     unsigned int flags;
-    unsigned int format;
     void *driverPrivate;
 } DRI2BufferRec, *DRI2BufferPtr;
 
+/* Version 2 structure (with format at the end) */
+typedef struct {
+    unsigned int attachment;
+    unsigned int name;
+    unsigned int pitch;
+    unsigned int cpp;
+    unsigned int flags;
+    void *driverPrivate;
+    unsigned int format;
+} DRI2Buffer2Rec, *DRI2Buffer2Ptr;
+

that part can't be correct. I don't really know what it's about maybe there 
should be a #ifdef or maybe one of them is just to much. at any rate it breaks 
the xf86-video-ati driver which neets the "format" component.

Silvio Frischknecht
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.x.org/archives/xorg-devel/attachments/20090706/33e07589/attachment.pgp 


More information about the xorg-devel mailing list