[PATCH] xinput: add set-prop command

Julien Cristau jcristau at debian.org
Mon Apr 20 06:15:30 PDT 2009


On Mon, Apr 20, 2009 at 14:12:50 +0200, Simon Thum wrote:

> Julien Cristau wrote:
>> v2: fixed the float handling for 64bit as Peter did for set-float-prop
> [...]
>> +    union {
>> +        unsigned char *c;
>> +        short *s;
>> +        long *l;
>> +        Atom *a;
>> +    } data;
> Wouldn't it be necessary to store Atoms long-aligned as well ?  
> (disclaimer: I did't look up the Atom definition, nor associated specs)
>
On the client side, Atom is unsigned long, so that should be ok.

One thing I'm wondering is if I should be more paranoid and also check
that format is 32 when type is FLOAT or ATOM.

Cheers,
Julien


More information about the xorg-devel mailing list