[PATCH] mi: if we fail to process 100 input events due to a stuck EQ, terminate.

Matthias Hopf mhopf at suse.de
Mon Apr 20 05:53:28 PDT 2009


On Apr 20, 09 15:40:47 +1000, Daniel Stone wrote:
> > Fair enough. Is there any way to "reliably" detect the difference?
> > I don't think making this optional is particularly useful, so dropping it is
> > probably better.
> 
> Why not just make the timeout _really_ long, e.g. about 15sec? You could
> make that cheap by just logging the timestamp of the event last popped
> out of the queue, and compare to the event you're trying to enqueue.  (Or
> the earliest timestamp of all the events in the queue, rather.)

It still opens up the can of worms labeled "Denial of Service".
Though one could argue that a graphics operation using 15secs is in
itself a possible denial of service...

> I guess you'd still need to make it command-line configurable for the
> gdb case, but yeah.

Definitely

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de


More information about the xorg-devel mailing list